Allow Dataset Creation API to take Template ID - #12405
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
5b23c8f to
ce7a795
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Test Results404 tests 389 ✅ 33m 52s ⏱️ Results for commit d5908b6. ♻️ This comment has been updated with latest results. |
ce7a795 to
e8f7f1f
Compare
This comment has been minimized.
This comment has been minimized.
|
@stevenwinship to support the SPA, we also need the Get Dataset API to return the template_id, can you add that to this PR? Or would it be better to have a separate issue? |
Update from Steve, this is already in the current PR. thanks! |
e8f7f1f to
665d78c
Compare
This comment has been minimized.
This comment has been minimized.
665d78c to
99a1d0e
Compare
This comment has been minimized.
This comment has been minimized.
|
@stevenwinship can you take a look at the Correctness issues, Test coverage and Style / motor sections of the Claude review above? |
48a1ed8 to
8d70f2e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Made fixes and added tests based on Claude |
This comment has been minimized.
This comment has been minimized.
|
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
@rtreacy I made changes based on the Claude review. Please re-review |
rtreacy
left a comment
There was a problem hiding this comment.
Previous review comments from Claude have been addressed
|
Hi @stevenwinship , could you resolve the conflicts? |


What this PR does / why we need it: Users creating Datasets need to be able to set the Template via the Create API
Which issue(s) this PR closes:#12132
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: