Skip to content

Allow Dataset Creation API to take Template ID - #12405

Open
stevenwinship wants to merge 9 commits into
developfrom
12132-dataset-creation-with-template
Open

Allow Dataset Creation API to take Template ID#12405
stevenwinship wants to merge 9 commits into
developfrom
12132-dataset-creation-with-template

Conversation

@stevenwinship

Copy link
Copy Markdown
Contributor

What this PR does / why we need it: Users creating Datasets need to be able to set the Template via the Create API

Which issue(s) this PR closes:#12132

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@stevenwinship stevenwinship self-assigned this May 22, 2026
@github-actions github-actions Bot added FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 10 A percentage of a sprint. 7 hours. SPA These changes are required for the Dataverse SPA SPA.Q4.2025.1 Create/Edit Template Feature Status: Needs Input Applied to issues in need of input from someone currently unavailable Type: Feature a feature request labels May 22, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project May 22, 2026
@coveralls

coveralls commented May 22, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 25.003% (-0.001%) from 25.004% — 12132-dataset-creation-with-template into develop

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project May 26, 2026
@stevenwinship stevenwinship removed their assignment May 26, 2026
@stevenwinship
stevenwinship force-pushed the 12132-dataset-creation-with-template branch 2 times, most recently from 5b23c8f to ce7a795 Compare May 26, 2026 18:17
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown

Test Results

404 tests   389 ✅  33m 52s ⏱️
 55 suites   15 💤
 55 files      0 ❌

Results for commit d5908b6.

♻️ This comment has been updated with latest results.

@stevenwinship
stevenwinship force-pushed the 12132-dataset-creation-with-template branch from ce7a795 to e8f7f1f Compare May 26, 2026 21:13
@github-actions

This comment has been minimized.

@ekraffmiller

Copy link
Copy Markdown
Contributor

@stevenwinship to support the SPA, we also need the Get Dataset API to return the template_id, can you add that to this PR? Or would it be better to have a separate issue?

@ekraffmiller

Copy link
Copy Markdown
Contributor

@stevenwinship to support the SPA, we also need the Get Dataset API to return the template_id, can you add that to this PR? Or would it be better to have a separate issue?

Update from Steve, this is already in the current PR. thanks!

@stevenwinship
stevenwinship force-pushed the 12132-dataset-creation-with-template branch from e8f7f1f to 665d78c Compare May 29, 2026 15:50
@github-actions

This comment has been minimized.

@stevenwinship
stevenwinship force-pushed the 12132-dataset-creation-with-template branch from 665d78c to 99a1d0e Compare June 1, 2026 13:03
@github-actions

This comment has been minimized.

@rtreacy

rtreacy commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@stevenwinship can you take a look at the Correctness issues, Test coverage and Style / motor sections of the Claude review above?

@stevenwinship
stevenwinship force-pushed the 12132-dataset-creation-with-template branch from 48a1ed8 to 8d70f2e Compare August 7, 2026 19:56
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@stevenwinship

Copy link
Copy Markdown
Contributor Author

Made fixes and added tests based on Claude

@stevenwinship stevenwinship removed their assignment Aug 11, 2026
@github-actions

This comment has been minimized.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
10.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12132-dataset-creation-with-template
ghcr.io/gdcc/configbaker:12132-dataset-creation-with-template

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@cmbz cmbz added the FY27 Sprint 4 FY27 Sprint 4 (2026-08-12 - 2026-08-26) label Aug 12, 2026
@stevenwinship

Copy link
Copy Markdown
Contributor Author

@rtreacy I made changes based on the Claude review. Please re-review

@rtreacy rtreacy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous review comments from Claude have been addressed

@github-project-automation github-project-automation Bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Aug 17, 2026
@rtreacy rtreacy removed their assignment Aug 17, 2026
@ChengShi-1 ChengShi-1 self-assigned this Aug 20, 2026
@ChengShi-1 ChengShi-1 moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Aug 20, 2026
@ChengShi-1

Copy link
Copy Markdown
Contributor

Hi @stevenwinship , could you resolve the conflicts?

@pdurbin pdurbin added the Status: Merge Conflicts Merge conflicts must be resolved. label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) FY26 Sprint 24 FY26 Sprint 24 (2026-05-20 - 2026-06-03) FY26 Sprint 25 FY26 Sprint 25 (2026-06-03 - 2026-06-17) FY26 Sprint 26 FY26 Sprint 26 (2026-06-17 - 2026-07-01) FY27 Sprint 1 FY27 Sprint 1 (2026-07-01 - 2026-07-15) FY27 Sprint 2 FY27 Sprint 2 (2026-07-15 - 2026-07-29) FY27 Sprint 3 FY27 Sprint 3 (2026-07-29 - 2026-08-12) FY27 Sprint 4 FY27 Sprint 4 (2026-08-12 - 2026-08-26) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 10 A percentage of a sprint. 7 hours. SPA.Q4.2025.1 Create/Edit Template Feature SPA These changes are required for the Dataverse SPA Status: Merge Conflicts Merge conflicts must be resolved. Type: Feature a feature request

Projects

Status: QA ✅

Development

Successfully merging this pull request may close these issues.

Support applying template id in API of dataset creation and persist dataset–template associations

7 participants