🐛 qooxdoo-kit: fix translation race in compiler (multi-app builds drop translations)

[odeimaiz]

Patches a race condition in @qooxdoo/compiler that causes translation catalogs to be dropped when several applications that share a library are compiled together. The fix is carried as a vendored patch applied to the compiler at image-build time.

Why

In osparc-simcore all 9 products (osparc, s4l, s4llite, s4lacad, …) share the
single osparc library and are compiled concurrently by qx compile. With the released
Spanish (es) translations, only one random product actually shipped the catalog; all
the others rendered English. On the deployed products qx.$$translations.es was empty
(Object.keys(...).length === 0) even though the bundle's qx.$$packageData[0].translations.es
was correct — the catalog was simply never written into those apps.

Root cause

A race in Analyser.getTranslation():

getTranslation: async function(library, locale) {
  var id = locale + ":" + library.getNamespace();
  var translation = t.__translations[id];
  if (!translation) {
    translation = t.__translations[id] = new Translation(library, locale); // cached synchronously
    translation.setWriteLineNumbers(this.isWritePoLineNumbers());
    await translation.checkRead();   // only the FIRST caller awaits the .po read
  }
  return translation;                // concurrent callers return the still-empty object
}

[Copilot]

Pull request overview

This PR vendors and applies a patch to @qooxdoo/compiler during the qooxdoo-kit image build to fix a concurrency bug where shared-library translation catalogs can be dropped in multi-app builds.

Changes:

• Add a patch (qx-compiler-translation-race.patch) that ensures concurrent callers of Analyser.getTranslation() all await translation.checkRead().
• Update the qooxdoo-kit Docker image to install patch and apply vendored patches to the installed compiler package at build time.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
qooxdoo-kit/patches/qx-compiler-translation-race.patch	Adds a targeted upstream patch to fix the translation read race in the compiler.
qooxdoo-kit/Dockerfile	Installs patch and applies the vendored patch(es) to @qooxdoo/compiler during image build.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[GitHK]

Q: why patch instead of updating the complier a version 1.0.5 is currently out?
We are using a 7 year old version 1.0.0-beta.20190807-0955

[odeimaiz]

Q: why patch instead of updating the complier a version 1.0.5 is currently out?

Because updating the compiler and framework have been in my list for a while, but it's not as easy as changing the number of the pinned version.

This solution is faster.