[qooxdoo-kit] Fix translations II#94
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the local patch applied to @qooxdoo/compiler to eliminate a translation-catalog race during concurrent builds, ensuring all concurrently-built applications reliably receive populated translation entries.
Changes:
- Expands the patch rationale to explain why
checkRead()alone can still allow an early-return before the catalog is fully populated. - Updates the patched
Analyser.getTranslation()logic to alwaysawait translation.checkRead()and additionallyawait translation.read()for all callers (not just the first).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66 and
pcrespov
June 19, 2026 11:59
matusdrobuliak66
approved these changes
Jun 19, 2026
giancarloromeo
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the local patch applied to @qooxdoo/compiler to eliminate a translation-catalog race during concurrent builds, ensuring all concurrently-built applications reliably receive populated translation entries.