feat: add cli support postgres pam#266
Conversation
|
💬 Discussion in Slack: #pr-review-cli-266-feat-add-cli-support-postgres-pam Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
| Filename | Overview |
|---|---|
| packages/pam/local/access.go | New file implementing the unified PAM access entry point; bypasses MFA/reason-required interactive flows, SSRF via relay host from API response, and a potential listener leak on metadata failure |
| packages/cmd/pam.go | Replaces resource/account-based sub-commands with a single path-based pam access <path> command; reason flag no longer prompts interactively (deferred to access.go flow) |
| packages/api/model.go | Adds Path and AccountType fields to PAM request/response structs; reorders RelayHost to appear earlier in PAMAccessResponse — no functional issues |
| packages/pam/local/base-proxy.go | Minor cleanup: moves reasonRequiredErrorName constant, updates comments to mark CallPAMAccessWithMFA as legacy, removes inline comments — no logic changes |
| packages/pam/local/database-proxy.go | Removes the old StartDatabaseLocalProxy function and dead imports; remaining Start/Run/handleConnection logic is unchanged |
Reviews (1): Last reviewed commit: "feat: add cli support postgres pam" | Re-trigger Greptile
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
Description 📣
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets