fix(release): Set AWS_DEFAULT_REGION in release workflow for S3 uploads and CloudFront invalidation#268
Conversation
…ds and CloudFront invalidation
|
💬 Discussion in Slack: #pr-review-cli-268-fix-release-set-aws-default-region-in-release-workflow-for-s3 Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
| Filename | Overview |
|---|---|
| .github/workflows/release_build_infisical_cli.yml | Adds AWS_DEFAULT_REGION: us-east-1 to two steps (S3 publish and CloudFront invalidation) that previously lacked a region, fixing AWS CLI failures in the release workflow. Region is hardcoded rather than driven by a secret/variable. |
Comments Outside Diff (1)
-
.github/workflows/release_build_infisical_cli.yml, line 264-278 (link)The region is hardcoded to
us-east-1in both steps. If the S3 bucket lives in a different region,aws s3commands will receive a redirect response and may fail with aPermanentRedirecterror (the AWS CLI does not always follow S3 redirects transparently). Storing the region in a repository secret or variable (e.g.INFISICAL_CLI_REPO_AWS_REGION) makes it consistent with the other credentials and lets the bucket migrate without a code change.
Reviews (1): Last reviewed commit: "fix(release): Set AWS_DEFAULT_REGION in ..." | Re-trigger Greptile
Description 📣
Type ✨