Add aggregator CLI commands for configuration parameters - #3438
Add aggregator CLI commands for configuration parameters#3438turmelclem wants to merge 15 commits into
Conversation
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Test Results 5 files ± 0 209 suites ±0 50m 22s ⏱️ - 2h 24m 50s Results for commit 0f67a96. ± Comparison against base commit bf1c9b3. This pull request removes 76 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
ddfd41b to
10aa1ef
Compare
b51783c to
39da965
Compare
…figuration, with verifier
2d65553 to
ccb24d2
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces new aggregator CLI commands to export/import protocol configuration markers, along with a new mithril-protocol-config reader interface/model and Cardano-chain message/payload encoding support to make protocol configuration markers portable and verifiable.
Changes:
- Add
protocol-configuration export-markers/import-markersCLI commands (JSON export + datum generation/import validation). - Add protocol-configuration “tools” and dependency injection wiring to read on-chain markers and generate signed datums.
- Add
mithril-protocol-configmodels/messages (CBOR encoding) + payload signing structure + test doubles.
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| mithril-stm/Cargo.toml | Switch ciborium to workspace dependency for consistent versioning. |
| mithril-common/src/entities/type_alias.rs | Add hex-encoded secret key type alias for protocol configuration markers. |
| mithril-common/src/crypto_helper/ed25519_alias.rs | Add ED25519 type aliases for protocol configuration markers signing/verifying. |
| mithril-common/Cargo.toml | Switch ciborium to workspace dependency. |
| mithril-aggregator/src/tools/protocol_configuration.rs | New tool: verify imported configs against chain window + build signed datum + datum size check. |
| mithril-aggregator/src/tools/mod.rs | Register/export ProtocolConfigurationTools. |
| mithril-aggregator/src/test/double/dummies.rs | Add Dummy impl for HumanReadableProtocolConfiguration for tests. |
| mithril-aggregator/src/dependency_injection/containers/protocol_configuration.rs | New DI container for protocol-configuration commands. |
| mithril-aggregator/src/dependency_injection/containers/mod.rs | Export the new protocol-configuration DI container. |
| mithril-aggregator/src/dependency_injection/builder/support/compatibility.rs | Add construction + getter for a ProtocolConfigurationMarkersReader (prod vs dummy). |
| mithril-aggregator/src/dependency_injection/builder/mod.rs | Add stored dependency + container creation method for protocol-configuration commands. |
| mithril-aggregator/src/configuration.rs | Add ProtocolConfigurationReaderParameters + ConfigurationSource accessor for reader params. |
| mithril-aggregator/src/commands/protocol_configuration_command.rs | Implement CLI subcommands, JSON IO, consistency checks, datum generation. |
| mithril-aggregator/src/commands/mod.rs | Wire new ProtocolConfiguration command into main CLI. |
| internal/mithril-protocol-config/src/test/double/mod.rs | Export new dummy markers reader from test doubles. |
| internal/mithril-protocol-config/src/test/double/dummy_markers_reader.rs | Add dummy ProtocolConfigurationMarkersReader for test environments. |
| internal/mithril-protocol-config/src/test/double/dummies.rs | Add dummies for protocol-configuration marker models/messages. |
| internal/mithril-protocol-config/src/model.rs | Add protocol configuration marker model + ConfigurationComputerFromMarkers helper with fallback lookup. |
| internal/mithril-protocol-config/src/lib.rs | Export cardano_chain module publicly. |
| internal/mithril-protocol-config/src/interface.rs | Add ProtocolConfigurationMarkersReader trait. |
| internal/mithril-protocol-config/src/cardano_chain/protocol_configuration_reader.rs | Add Cardano-chain reader type for markers (currently stubbed). |
| internal/mithril-protocol-config/src/cardano_chain/payload.rs | Add payload structs and signing helper for protocol configuration markers. |
| internal/mithril-protocol-config/src/cardano_chain/mod.rs | Add Cardano-chain module exports for message/payload/reader. |
| internal/mithril-protocol-config/src/cardano_chain/message.rs | Add CBOR message/codec for protocol configuration markers. |
| internal/mithril-protocol-config/Cargo.toml | Add dependencies needed for CBOR/hex/serde + chain reader integration. |
| Cargo.toml | Add workspace ciborium dependency. |
| Cargo.lock | Lockfile updates for new deps/crate wiring. |
Suppressed comments (1)
mithril-aggregator/src/commands/protocol_configuration_command.rs:345
- User-facing CLI output contains spelling/grammar issues ("Sucessfuly write"), which makes the command output look unpolished.
println!(
"Sucessfuly write Tx datum file at {}",
self.target_path.to_string_lossy()
);
ccb24d2 to
95471fe
Compare
…rsion, signature and generating tx datum for protocol configuration command
…ct to avoid missing signing when generating protocol config tx datum
…empty read impl for cardano chain adapter
…s with fallback logic for ProtocolConfigurationReader
…d on chain configurations
protocol configutation markers
…ion consistency for protocol-configuration import command
…rification on protocol-configuration command
…m, and rework protocol-configuration command parameters
ad5d80a to
aba2fbb
Compare
…eader, and using dedicated struct for CBOR conversion
aba2fbb to
0f67a96
Compare
Content
aggregator cli :
protocol-config :
Pre-submit checklist
Issue(s)
this PR closes #3392