Skip to content

refactor(stm): Reuse the cached unsafe SRS in the SNARK test setups - #3443

Draft
damrobi wants to merge 5 commits into
mainfrom
damrobi/msnark/3433-reuse-cached-unsafe-srs
Draft

refactor(stm): Reuse the cached unsafe SRS in the SNARK test setups#3443
damrobi wants to merge 5 commits into
mainfrom
damrobi/msnark/3433-reuse-cached-unsafe-srs

Conversation

@damrobi

@damrobi damrobi commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Content

This PR includes an update to the way we use the unsafe SNARK setup in tests in order to reduce the runtime of the tests.

Gain in test time

Baseline: 1h11m47s (nightly 30/07 https://github.com/IntersectMBO/mithril/actions/runs/30506077425/job/90756011560)

After commit 1: 1h00m56s (https://github.com/IntersectMBO/mithril/actions/runs/30538872179/job/90858636858)

After commit 2: 40m50s (https://github.com/IntersectMBO/mithril/actions/runs/30552401815/job/90904114168?pr=3443)

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Comments

Issue(s)

Closes #3433

@damrobi damrobi self-assigned this Jul 30, 2026
@damrobi damrobi added the run-slow-tests Technical label to run slow tests tiers in the CI. label Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

Test Results

     5 files  ±0     209 suites  ±0   1h 50m 10s ⏱️ - 1h 25m 2s
 3 411 tests +5   3 411 ✅ +5  0 💤 ±0  0 ❌ ±0 
11 180 runs  +5  11 180 ✅ +5  0 💤 ±0  0 ❌ ±0 

Results for commit 440fee2. ± Comparison against base commit bf1c9b3.

♻️ This comment has been updated with latest results.

@damrobi
damrobi force-pushed the damrobi/msnark/3433-reuse-cached-unsafe-srs branch from 46c9d3e to 875d634 Compare July 31, 2026 09:09
@damrobi
damrobi deployed to testing-2-preview July 31, 2026 16:24 — with GitHub Actions Active
@damrobi
damrobi deployed to testing-preview July 31, 2026 16:24 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-slow-tests Technical label to run slow tests tiers in the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reuse the cached unsafe SRS in the SNARK test setups

1 participant