Skip to content

Review mflux main through #828 in the drift guard, with float16-compute parity - #57

Merged
IonDen merged 1 commit into
mainfrom
test/0147-reviewed-main-820
Oct 7, 2026
Merged

IonDen merged 1 commit into
mainfrom
test/0147-reviewed-main-820

Conversation

@IonDen

@IonDen IonDen commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

The test job that runs against mflux's main branch went red after mflux-community/mflux#820, which adds an opt-in float16 compute mode for attention and feed-forward on FLUX.2, Z-Image and Qwen-Image 2.1. This PR reviews that change and moves the drift guard's reviewed commit forward. It changes tests only, so there is no release.

#820 changed two functions TeaCache wraps, Flux2Klein.generate_image and ZImage.generate_image, and in both only the image-metadata call: it now passes the compute setting as generation_parameters (in Z-Image, next to the existing float32 entry). TeaCache passes that return value through. The float16 setting itself lives on mflux's attention and feed-forward modules, which TeaCache calls rather than copies, so a TeaCache run picks it up as plain mflux does. No code TeaCache copies reads it.

To confirm that, the weight-free parity test now builds small real Z-Image and FLUX.2 transformers with the float16 option on and checks that TeaCache's gated forward at threshold 0 is bit-identical to the transformer's own call, with and without CFG. The cases skip on mflux releases that do not have the option. On FLUX.2 the tiny transformer's block weights are scaled up so float16 compute actually changes the output; at the default initialisation the two were identical and the check would have proved nothing, and a guard test keeps that from regressing.

The reviewed commit moves from 04fc101 to e50215c, which also contains #824, #813 and #828. Those three are off TeaCache's paths: #824 changes how the initializers load a baked LoRA, #813 adjusts test tolerances and #828 a CLI warning. The two generate_image fingerprints are the only ones that changed. On a git install of mflux, the parity cases now fail instead of skipping if the bfloat16 stream or the float16 option disappears, so an upstream rename cannot silently turn the check off. The fast tests pass on mflux 0.21.0 and on mflux main at e50215c.

@IonDen IonDen added the dependencies Pull requests that update a dependency file label Oct 5, 2026
@IonDen IonDen self-assigned this Oct 5, 2026
@IonDen
IonDen force-pushed the test/0147-reviewed-main-820 branch from 3326297 to b62eb4f Compare October 5, 2026 16:47
@IonDen IonDen changed the title Review mflux main through #820 (float16 compute) in the drift guard Review mflux main through #828 in the drift guard, with float16-compute parity Oct 5, 2026
@IonDen
IonDen force-pushed the test/0147-reviewed-main-820 branch from b62eb4f to 541398f Compare October 5, 2026 16:50
@IonDen
IonDen merged commit bb5cb62 into main Oct 7, 2026
14 checks passed
@IonDen
IonDen deleted the test/0147-reviewed-main-820 branch October 7, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant