Skip to content

add ordering for icons in tray - #1626

Open
MrFantOlas wants to merge 2 commits into
JakeStanger:masterfrom
MrFantOlas:tray
Open

MrFantOlas wants to merge 2 commits into
JakeStanger:masterfrom
MrFantOlas:tray

Conversation

@MrFantOlas

Copy link
Copy Markdown
Contributor

Closes #1489.

The wiki has been update to match the newly available behavior.
This also includes removing previous tray objects that where still held in memory.

@github-actions github-actions Bot added the Z:Review Required Pull request pending review label Sep 25, 2026
@JakeStanger

Copy link
Copy Markdown
Owner

Thanks for this. It looks like the IDs are stable/predictable enough I'm happy with this approach, although my only concern is how these can be obtained.

If they can't be easily queried already, we'll need to build in ironvar support into the tray client so these can be pulled out over IPC.

@JakeStanger JakeStanger removed the Z:Review Required Pull request pending review label Sep 25, 2026
@MrFantOlas

MrFantOlas commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Apart from looking into the debug logs, I do not of any other way. That said, guess work is probably the most effective way as they all contain their names within the id (hence also the match for containing). For example although the id for discord is not discord because it is contained putting the name of the app is very good guess. It has worked for me in the 10 ish apps I have tested.

@JakeStanger

Copy link
Copy Markdown
Owner

Okay I'm not a fan of putting it down to guesswork, even if it's obvious in most cases. I think I want to see a way of querying the IDs before I merge this in, and probably follow up by documenting some common programs.

Happy to pick that work up myself in the next couple of weeks unless you want to.

@JakeStanger JakeStanger added the Z:Review Required Pull request pending review label Sep 27, 2026
@MrFantOlas

Copy link
Copy Markdown
Contributor Author

As you wish I do not mind adding a commit to this PR.

@JakeStanger

Copy link
Copy Markdown
Owner

Cool, appreciate it. If you want to have a look at implementing ironvar::Namespace for the tray client I think that'd be the best way. Not really sure how easy that'll be so if it gets too bad let me know.

@MrFantOlas

Copy link
Copy Markdown
Contributor Author

I think this looks ok. Let me know !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z:Review Required Pull request pending review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define order of tray icons

2 participants