Volume: add ability to overwrite device name in format - #1636
Open
MrFantOlas wants to merge 1 commit into
Open
MrFantOlas wants to merge 1 commit into
MrFantOlas wants to merge 1 commit into
Conversation
JakeStanger
changed the title
Owner
|
Thanks, looks mostly good. Can this be changed to Agreed - I don't think this needs IPC implementation as the names are easily discoverable through the UI. |
JakeStanger
added
Z:Changes Requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #885.
I think this also helps with #1031, but I do not know if this satisfies fully.
Let me know if you also want to add IPC support to discover device names. I considered them easily discoverable as they appear in the source and sink selection menu.