Skip to content

Fix the issue of Residence detection occupying the main thread - #374

Merged
Jikoo merged 4 commits into
Jikoo:masterfrom
NeglectDream:master
May 12, 2026
Merged

Fix the issue of Residence detection occupying the main thread#374
Jikoo merged 4 commits into
Jikoo:masterfrom
NeglectDream:master

Conversation

@NeglectDream

Copy link
Copy Markdown
Contributor

Modify territory detection to Residence internal API implementation
The utilization rate of the main thread ranges from 0.7% to significantly less than 0.01%

@Jikoo Jikoo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't add any dependency information for Residence. How is this supposed to compile?

The reason Residence is EoL and exists as a precompiled hook is that (at least last I was aware) they do not offer any way to use their API via Maven. Their project was structured for manual compilation by a particular IDE, so JitPack didn't even work. See also https://github.com/Jikoo/Regionerator/wiki/Hooks#adding-support

If they still are incompatible with the Maven ecosystem, you can just make a plugin that relies on both Regionerator and Residence and register the hook from it yourself.

@NeglectDream

Copy link
Copy Markdown
Contributor Author

I added the corresponding builder for Residence in maven, and now the project can build itself
@Jikoo

@Jikoo Jikoo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so they actually support JitPack now? That's good news.

Comment thread pom.xml Outdated
Comment thread pom.xml Outdated

@Jikoo Jikoo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@Jikoo
Jikoo merged commit 165062a into Jikoo:master May 12, 2026
2 checks passed
lijinhong11 added a commit to lijinhong11/Regionerator-Paper that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants