Added support for Xcode 9 and Swift 4.1 and iOS 11.3#778
Open
yogeshmanghnani wants to merge 2 commits into
Open
Added support for Xcode 9 and Swift 4.1 and iOS 11.3#778yogeshmanghnani wants to merge 2 commits into
yogeshmanghnani wants to merge 2 commits into
Conversation
|
Confirmed that this works. Thanks! |
phoney
reviewed
May 1, 2018
| { | ||
| if ( symetry < 0 ) *pRevealWidth = _rightViewRevealWidth, *pRevealOverdraw = _rightViewRevealOverdraw; | ||
| else *pRevealWidth = _rearViewRevealWidth, *pRevealOverdraw = _rearViewRevealOverdraw; | ||
| if ( symetry < 0 ) (void)(*pRevealWidth = _rightViewRevealWidth), *pRevealOverdraw = _rightViewRevealOverdraw; |
There was a problem hiding this comment.
This is not the normal way to write this code. Just add braces and semicolons.
if ( symetry < 0 ) {*pRevealWidth = _rightViewRevealWidth; *pRevealOverdraw = _rightViewRevealOverdraw; }
else {*pRevealWidth = _rearViewRevealWidth; *pRevealOverdraw = _rearViewRevealOverdraw; }
Those void's are just not normally used like that.
|
Where can I d/l the newest version with all the fixes for Xcode 9 and Swift 4.1 and iOS 11.3? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the warnings and errors removed for Xcode 9 and Swift 4.1 and iOS 11.3