Skip to content

Fix on 32 bit Julia#359

Merged
TimG1964 merged 1 commit into
JuliaData:masterfrom
davidanthoff:davidanthoff/issue358
Mar 31, 2026
Merged

Fix on 32 bit Julia#359
TimG1964 merged 1 commit into
JuliaData:masterfrom
davidanthoff:davidanthoff/issue358

Conversation

@davidanthoff

Copy link
Copy Markdown
Contributor

Fixes #358. Hopefully, this was largely done with Claude.

@codecov-commenter

codecov-commenter commented Mar 31, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.62%. Comparing base (e565d8a) to head (ac991d1).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/workbook.jl 50.00% 3 Missing ⚠️
src/cell.jl 83.33% 1 Missing ⚠️
src/styles.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   94.64%   94.62%   -0.03%     
==========================================
  Files          21       21              
  Lines        7046     7051       +5     
==========================================
+ Hits         6669     6672       +3     
- Misses        377      379       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TimG1964

Copy link
Copy Markdown
Collaborator

Thank you very much for this. I hadn't considered 32bit at all and it seems like it had never been supported (many of your changes are to early code sections).

@TimG1964 TimG1964 merged commit aad8d78 into JuliaData:master Mar 31, 2026
21 checks passed
@davidanthoff davidanthoff deleted the davidanthoff/issue358 branch March 31, 2026 17:57
@davidanthoff

Copy link
Copy Markdown
Contributor Author

Could you maybe tag a new release also? I'm trying to fix some CI runs downstream, and once things are tagged we should be good :)

@TimG1964

Copy link
Copy Markdown
Collaborator

I will. It'll be tomorrow now though, I'm afraid.

@TimG1964

Copy link
Copy Markdown
Collaborator

Maybe a cheeky request @davidanthoff, but can you reciprocate by responding to this PR on ExcelFiles?

At present, FileIO docs say it will read/write Excel files but this isn't true and hasn't been for quite a few years. I don't think this kind of misrepresentation is helpful.

Thanks. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MethodError on 32-bit Julia: sst_unformatted_string accepts ::Int but caller passes Int64

3 participants