clean #90 backport - #91
Open
mofeing wants to merge 2 commits into
Open
Conversation
simeonschaub
approved these changes
Aug 17, 2026
Pangoraw
reviewed
Aug 19, 2026
Comment on lines
+119
to
120
| fname = mod_name === nothing ? "" : String(mod_name) | ||
| fname = "module_" * lpad(MLIR_DUMP_COUNTER[], 3, "0") * "_$(fname)" |
Member
There was a problem hiding this comment.
maybe something like this to prevent a trailing _ ?
Suggested change
| fname = mod_name === nothing ? "" : String(mod_name) | |
| fname = "module_" * lpad(MLIR_DUMP_COUNTER[], 3, "0") * "_$(fname)" | |
| fname = mod_name === nothing ? "" : "_" * String(mod_name) | |
| fname = "module_" * lpad(MLIR_DUMP_COUNTER[], 3, "0") * fname |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i wasn't aware of #90 but there are things that shouldn't have been merged. there are a couple of differences with the Reactant copy of MLIR.jl:
mlirOperationInject(used bytryinject!) is implemented only in libReactantExtra, so any other build of libMLIR will error because it won't find the symbol. also, it was more an useful experiment at the time, that seen in perspective now, it wasn't maybe a great idea and we should probably remove it.cc @simeonschaub