Skip to content

Update breakage: use organization-wide workflow - #200

Merged
tmigot merged 3 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage
Sep 6, 2026
Merged

tmigot merged 3 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage

Conversation

@MaxenceGollier

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings May 1, 2026 14:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s “Breakage” CI to delegate implementation to the JuliaSmoothOptimizers organization-wide reusable workflows (per JuliaSmoothOptimizers/.github#18), removing the previously in-repo breakage implementation.

Changes:

  • Replace the local Breakage.yml implementation with a call to JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml.
  • Add a CommentBreakage.yml workflow to post results via an org-wide reusable workflow triggered by workflow_run.
  • Remove the local .breakage Julia helper script and its dedicated project file.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
.github/workflows/CommentBreakage.yml Adds a workflow_run-triggered job that calls the org-wide PR-commenting reusable workflow.
.github/workflows/Breakage.yml Replaces the large in-repo workflow with a call to the org-wide reusable Breakage workflow.
.breakage/get_jso_users.jl Removes the local dependency-discovery helper script.
.breakage/Project.toml Removes the local project file used by the deleted helper script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/Breakage.yml
Comment thread .github/workflows/Breakage.yml Outdated
Comment thread .github/workflows/CommentBreakage.yml
Comment thread .github/workflows/CommentBreakage.yml Outdated
Comment thread .github/workflows/Breakage.yml

@tmigot tmigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxenceGollier ! This one needs the formatting we mentioned before.

Comment thread .github/workflows/CommentBreakage.yml Outdated
@tmigot

tmigot commented Sep 6, 2026

Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

@tmigot
tmigot merged commit 49803f7 into JuliaSmoothOptimizers:main Sep 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants