Remove Percival from AMPL examples - #202
Merged
Merged
Conversation
… to missing linear API support AmplNLReader does not support the linear API that Percival's SlackModel requires. Only Ipopt is now used for AMPL problems in the benchmark examples.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the AMPL benchmarking example to only use solvers supported by AmplNLReader, removing the unsupported Percival/SlackModel path from the example workflow.
Changes:
- Removes
Percivalfrom the AMPL benchmark example imports. - Removes the Percival solver entry so AMPL benchmarks run only with Ipopt.
- Adds a note explaining why Percival is excluded.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmigot
requested changes
Apr 6, 2026
Contributor
Author
|
@tmigot Made the changes |
Removed unused imports and redundant solver definitions.
Member
|
@dpo What do you think of this solution? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 76.71% 86.19% +9.48%
==========================================
Files 12 10 -2
Lines 292 297 +5
==========================================
+ Hits 224 256 +32
+ Misses 68 41 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dpo
approved these changes
Apr 7, 2026
tmigot
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpo @tmigot
AmplNLReader does not support the linear API that Percival's SlackModel requires. Only Ipopt is now used for AMPL problems in the benchmark examples.
Fixes #172