Widen JSON compat bound to include 1.x - #206
Merged
Merged
Conversation
SolverBenchmark's JSON compat (0.20.0, 0.21.0) does not overlap with CUTEst.jl's JSON = "1.5" requirement (since CUTEst v1.3.8, 2026-04-21), so no environment can depend on both packages at once. This breaks DCISolver.jl's docs build, which uses CUTEst and SolverBenchmark together (see JuliaSmoothOptimizers/DCISolver.jl#193, https://github.com/JuliaSmoothOptimizers/DCISolver.jl/actions/runs/31178054731). The only JSON usage in src/ is JSON.parse in pkgbmark.jl's to_gist, whose result is handed to GitHub.jl as an AbstractDict. JSON.jl 1.x's JSON.parse returns a JSON.Object <: AbstractDict, so the call site is unaffected by the rewrite. Verified the full test suite passes with JSON resolved to 1.6.1.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
Claude is wrong here. You have a compat entry Julia can install CUTEst 1.3.7 and the last release of The failure is related to the download of the SIF files because an old archive that was cached. However, it is still a good idea to allow JSON 1 for the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SolverBenchmark's
JSONcompat bound (0.20.0, 0.21.0) does not overlap with CUTEst.jl'sJSON = "1.5"requirement (in place since CUTEst v1.3.8, released 2026-04-21, unchanged in the current v1.4.0). Because the bounds don't intersect at all, no environment can depend on both SolverBenchmark and a recent CUTEst simultaneously — Pkg's resolver reports "Unsatisfiable requirements detected for package JSON".Concretely this breaks DCISolver.jl's docs build:
docs/src/2-benchmark.mduses CUTEst (to select/load problems) together with SolverBenchmark (bmark_solvers,pretty_stats,performance_profile) on the same page, and that combination currently fails to resolve. See JuliaSmoothOptimizers/DCISolver.jl#193 (https://github.com/JuliaSmoothOptimizers/DCISolver.jl/actions/runs/31178054731).Investigation
JSONpackage insrc/isJSON.parseinsrc/pkgbmark.jl'sto_gist, which builds the gist payload later handed toGitHub.create_gist(which itself callsJSON.json(params)to serialize the request body).JSON.parse's return value (JSON.Object{String,Any}) is still<: AbstractDict, matching the interfaceGitHub.jlexpects. A standalone script replicating the exactto_gistcode path round-trips correctly under JSON 1.6.1.to_gist/JSON directly, so I additionally ran the full test suite (Pkg.test()) with JSON forced to resolve to 1.6.1 (clean git tree, sincetest_pkgbmark()requires one) — it passes identically to the JSON 0.21.4 baseline:Testing SolverBenchmark tests passedin both cases.Change
Widen the
JSONcompat entry from"0.20.0, 0.21.0"to"0.20.0, 0.21.0, 1".Test plan
Pkg.test()passes with JSON resolved to 0.21.4 (clean tree baseline)Pkg.test()passes with JSON resolved to 1.6.1 (clean tree)to_gist'sJSON.parse/JSON.jsonround-trip under JSON 1.6.1🤖 Generated with Claude Code
https://claude.ai/code/session_01XqAvZUtSdcxUHuNfzJdkHZ