Conversation
rsenne
marked this pull request as draft
September 25, 2026 21:45
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## part3b-hsmm-forward #171 +/- ##
=======================================================
+ Coverage 97.10% 97.62% +0.52%
=======================================================
Files 25 25
Lines 897 843 -54
=======================================================
- Hits 871 823 -48
+ Misses 26 20 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Yeah that doesn't seem like it's worth the additional dep. Let's keep things as they are for now! Thanks for giving it a shot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I prototyped
OhMyThreads.jl. To be honest I'm not sure its worth it. We can probably abstract the current code without the new libraries/dep.Benchmark:
Setup: Julia 1.13.0, 4 threads (
julia -t 4), N = 8 states, Normal emissions, (minimum time)."Very different lengths" = 200 sequences, each 5000 long with probability 0.1, otherwise 100.
forward_backward!viterbi@threads(current)DynamicScheduler@threads(current)DynamicScheduler