fix(cuda): pin speculative expert kernel family - #1234
Merged
Merged
Conversation
ZacharyZcR
force-pushed
the
fix/cuda-spec-kernel-pin
branch
from
August 28, 2026 02:06
26b6d05 to
9f4a8d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SPEC_PINto the synchronous CUDA grouped-expert path so speculative verification cannot switch into row-count-gated W4A4 or W4A16 Tensor Core kernelsThis addresses the uncovered CUDA half of #689: CPU dispatch was already pinned, while CUDA grouped experts could still change numeric families with verify-row depth. The existing non-speculative path is unchanged.
Verification
make -C c test-cmake -C c glmmake -C c glm CUDA_DLL=1 CC=x86_64-w64-mingw32-gccgit diff --checktest_backend_cudanow checks that a pinned group remains byte-identical to the small-batch grouped path even when W4A4 or W4A16 Tensor Core dispatch is enabled. This host has no NVIDIA GPU, so H100/H200 deep-draft token identity and acceptance-rate reproduction remains a hardware validation gate rather than a claimed result.