Repository navigation
tests: dashboard tests wait for HITS and PROF before reading them - #1821
Merged
Merged
Conversation
The engine writes HITS and PROF after DONE. The gateway answers the request as soon as it reads DONE, and its dispatcher reads the two lines a moment later, so a test that queries /experts right after the reply can see the empty grid. That is what turned dev red on the merge of #1819 (test_dsv41_dashboard: 0 != 12). The qwen36 and glm53 dashboard tests read the endpoints the same way. The tests now wait until each endpoint's seq says its line arrived, up to 30 s, then assert as before.
Yi-111-a
added a commit
to Yi-111-a/colibri
that referenced
this pull request
Oct 1, 2026
Catch up past JustVugg#1821 so the branch includes the serve-variant and MiMo-Pro docs that landed after the first merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev went red on the merge of #1819 in the "DeepSeek V4.1 tiny oracle" job, and green again on the next merge:
#1819 only touched
mimo.cand the family registry; the cause is a race in the test. The engine writesHITSandPROFafterDONE. The gateway answers the HTTP request as soon as its dispatcher readsDONE, and the dispatcher reads the two lines after that, so a test that queries/expertsright after the reply can see the grid before this turn's hits arrive. The qwen36 and glm53 dashboard tests read the endpoints the same way.The endpoints already return a
seqthat counts the lines received. The three tests now wait untilseq >= 1on/expertsand/profile(up to 30 s; past that they return what is there and the existing assertions name what is missing).Checked
time.sleep(0.5)before the gateway recordsHITS, the test on dev fails exactly as on CI (0 != 12), and with this change it passes.