Conversation
Owner
|
Thanks for splitting this out. As it stands we cannot take it, for these reasons:
If you want |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits out the
RAM_GBpart of #1564, as requested. Rebuilt from scratch on currentdev(4521832a) so it carries no unrelated changes.Problem
RAM_GBis documented as a whole-process memory ceiling, but the expert cache was sized from a request that ignored it. A caller could ask for a cache the machine cannot hold, and the refusal only triggered on a Linux-only/proc/meminfopath, so the same request silently succeeded on macOS and Windows.Change
qwen36_cap_for_ram(budget_gb, resident_gb, reserve_gb, slot_gb, layers, requested, n_experts, &left).0when not even one slot fits.compat_mem_available_gb()instead of adding a second probe.c/tests/test_qwen36_ctx.cgainscase_ram_budget, covering clamp-down, never-raise, no-slot-fits, and never-exceeds-expert-count.Verification
Rebuilt onto current
dev; no upstream file is removed or reverted (0 deletions of existing lines).make qwen36— clean, 0 warningsmake test-c— full suite passestest_qwen36_ctx— passesIdentical to pristine
devon the same containers.Notes
This replaces the
RAM_GBportion of #1564. The rest of that PR is still being split out separately; this one stands alone and can be reviewed and merged on its own.