Repository navigation
Add Duplexmatrixscanner - #1138
Merged
Merged
Conversation
DuplexMatrixScanner first scans COL2ROW and then ROW2COL.
Member
|
Can you make it pass the automated tests? It currently trips on formatting, that is fixed with |
regicidalplutophage
self-requested a review
April 9, 2026 01:52
regicidalplutophage
requested changes
Apr 9, 2026
regicidalplutophage
left a comment
regicidalplutophage
left a comment
Member
There was a problem hiding this comment.
Split the new scanner into its own file please
regicidalplutophage
self-requested a review
April 9, 2026 11:11
regicidalplutophage
approved these changes
Apr 9, 2026
regicidalplutophage
requested changes
Apr 9, 2026
regicidalplutophage
self-requested a review
April 9, 2026 11:19
regicidalplutophage
approved these changes
Apr 9, 2026
Contributor
Author
|
I am glad it is merged! Thanks for the support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The digitalio DuplexMatrixScanner dynamically switch GPIO pins that can change between input and output modes during the scan cycle; this allows to first scan COL2ROW and then ROW2COL.