Conversation
…empty evaluations
There was a problem hiding this comment.
This PR successfully separates test layers and closes invocation/scope coverage gaps. The implementation properly distinguishes behavior tests (fast, no database) from integration tests (real PostgreSQL), with appropriate network isolation and CI jobs for each layer.
Key improvements validated:
- Test classification via pytest hooks correctly identifies database dependencies and prevents conflicting markers
- Network isolation fixture blocks external calls in behavior tests while preserving PostgreSQL access for integration tests
- Evaluation runner now returns distinct exit codes: 0 (success), 1 (failure), 2 (insufficient evidence)
- Database safety checks prevent accidental use of non-disposable database names
- CI workflow properly configures separate jobs with appropriate timeouts and service dependencies
The changes maintain backward compatibility while enabling independent execution of test layers. All 21 files modified follow consistent patterns and proper error handling.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 912-case suite could stay green with Explorer/Thinker invocation disabled or guidance applicability bypassed. This change separates deterministic behavior checks, real database integration, and evidence-based AI outcome review, and closes those demonstrated coverage gaps.
Validation: 934 passed in 21.49s with coverage; 735 behavior and 199 integration cases also pass independently. The new checks detect all seven disabled-invocation scenarios and six applicability-bypass scenarios. Evaluation failures/empty tiers failed before their fix and pass afterward. The wrapper rejects non-disposable database names. Existing SQLite ResourceWarnings and the Starlette deprecation warning remain documented.
Application capture, retrieval, model prompts/configuration, and steering-approval behavior are unchanged. The executable runtime change is confined to evaluation reporting and exit status.
Clean GitHub validation: both
behaviorandintegrationjobs passed at commit bb1573b (run). The compact consensus table also detects the two-vote threshold fault (7 expected failures).