Repository navigation
Add clang tidy - #420
Open
charles-lunarg wants to merge 13 commits into
Open
Add clang tidy#420charles-lunarg wants to merge 13 commits into
charles-lunarg wants to merge 13 commits into
Conversation
charles-lunarg
force-pushed
the
add_clang_tidy
branch
5 times, most recently
from
October 5, 2026 22:08
05bb9b0 to
3c1ac14
Compare
Header and Source file used different parameter names, unified them to share a name for readability.
The API takes things by single pointer but many tests are passing a double pointer. Make it explicit by using the appropriate cast.
Bad style to have an assignment occurring inside of a conditional.
This prevents accidental conversions from taking place.
Move operators should never throw.
Signed bitwise ops can be confusing and is easy to invoke undefined behavior.
Adds the CMake build option USE_CLANG_TIDY that enables clang-tidy checks. The .clang-tidy file configures the settings to apply everywhere while the tests/.clang-tidy only applies to the tests, that way nuisance checks can be disabled for tests (such as const correctness). format.yml was renamed to lint.yml as it now contains a step to run the project with clang-tidy enabled.
VkClusterAccelerationStructureOpInputNV is a union of pointers, and the safe struct has special functionality for handling unions of pointers.
charles-lunarg
force-pushed
the
add_clang_tidy
branch
from
October 12, 2026 20:01
3c1ac14 to
43ae331
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.