Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/SegmentGroupControls.vue
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,8 @@ function deleteSelected() {
</template>

<style>
.segment-group-list {
/* Override Vuetify's hidden overflow for lists inside navigation drawers. */
.v-navigation-drawer .v-list.segment-group-list {
max-height: 240px;
overflow-y: auto;
}
Expand Down
4 changes: 4 additions & 0 deletions tests/pageobjects/volview.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,10 @@ class VolViewPage extends Page {
return $$('button[data-testid="segment-group-save-button"]');
}

get segmentGroupList() {
return $('.segment-group-list');
}

get saveSegmentGroupFilenameInput() {
return this.activeDialog.$('#filename');
}
Expand Down
29 changes: 29 additions & 0 deletions tests/specs/segment-group-list-scroll.e2e.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { volViewPage } from '../pageobjects/volview.page';
import { openUrls } from './utils';
import { PROSTATEX_DATASET } from './configTestUtils';

// Six 48px rows overflow the list's 240px cap.
const GROUP_COUNT = 6;

describe('Segment group list', () => {
it('lets overflowing segment groups scroll', async () => {
await openUrls([PROSTATEX_DATASET]);

for (let i = 0; i < GROUP_COUNT; i++) {
await volViewPage.createSegmentGroup(`Group ${i + 1}`);
}

const list = await volViewPage.segmentGroupList;
await list.waitForDisplayed();

const rows = await list.$$('.v-list-item');
expect(rows.length).toEqual(GROUP_COUNT);

const scrollHeight = Number(await list.getProperty('scrollHeight'));
const clientHeight = Number(await list.getProperty('clientHeight'));
expect(scrollHeight).toBeGreaterThan(clientHeight);

const overflowY = await list.getCSSProperty('overflow-y');
expect(overflowY.value).toEqual('auto');
});
});
Loading