Repository navigation
Remove dead code from DRF and properly authenticate with Django OAuth Toolkit - #302
Conversation
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Got around to testing this and everything I checked seems to work properly.
All this seems to be leftover stuff before I swapped to using ninja for everything.
This was good because it led to be testing and looking at some client code.
I did a check of the client side code for the api and realized there are some references to proccessing-task and processing-task/filtered that don't have endpoints. I created an issue for it here: #306
Otherwise I think this is good to merge in.
brianhelba
changed the title
|
@naglepuff @BryonLewis Can you take a look again? I rewrote the authentication function to use the correct logic from Django OAuth Toolkit; I'm not sure why the old one was implemented that way. |
|
Actually, I'm going to split out my change to the auth function, since it's causing tests to break, and the rest was already approved. |
3 participants
No description provided.