Skip to content

Fix dimensionality bug in num_observations - #343

Merged
guilhermebodin merged 1 commit into
masterfrom
rs/fix-dimension
Jun 8, 2026
Merged

Fix dimensionality bug in num_observations#343
guilhermebodin merged 1 commit into
masterfrom
rs/fix-dimension

Conversation

@raphaelsaavedra

Copy link
Copy Markdown
Member

length(model.system.y) works fine for the univariate case, but in multivariate cases where y is a matrix, length will return n_rows * n_cols which is not what we want. size(y, 1) works as intended for both vectors and matrices.

@raphaelsaavedra raphaelsaavedra self-assigned this Jun 5, 2026
@raphaelsaavedra raphaelsaavedra added the bug Something isn't working label Jun 5, 2026
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (0b0198d) to head (1a76a29).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files          36       36           
  Lines        3713     3713           
=======================================
  Hits         3390     3390           
  Misses        323      323           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guilhermebodin
guilhermebodin merged commit 6b97582 into master Jun 8, 2026
7 checks passed
@guilhermebodin
guilhermebodin deleted the rs/fix-dimension branch June 8, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants