Skip to content

Orientation parameter for RealSphericalHarmonicsDirectivity module.#438

Merged
fakufaku merged 2 commits into
LCAV:masterfrom
je-fleischhauer:harmonics-orientation
Jun 26, 2026
Merged

Orientation parameter for RealSphericalHarmonicsDirectivity module.#438
fakufaku merged 2 commits into
LCAV:masterfrom
je-fleischhauer:harmonics-orientation

Conversation

@je-fleischhauer

Copy link
Copy Markdown
Contributor

I added an orientation parameter to the RealSphericalHarmonicsDirectivity module. I created a unit test to check that the orientation parameter works, and updated the CHANGELOG file.

  • [] Are there docstrings ? Do they follow the numpydoc style ?
  • [] Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • [] Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • [] Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • [] Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

Happy PR 😃

@fakufaku
fakufaku self-requested a review June 26, 2026 02:51

@fakufaku fakufaku left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@fakufaku
fakufaku merged commit a8fc3fb into LCAV:master Jun 26, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants