fix(docker): replace deprecated dbms.* neo4j settings with server.* (#398)#483
Open
prdai wants to merge 2 commits into
Open
fix(docker): replace deprecated dbms.* neo4j settings with server.* (#398)#483prdai wants to merge 2 commits into
prdai wants to merge 2 commits into
Conversation
Neo4j 5.x emits deprecation warnings on startup for the legacy `dbms.directories.*` and `dbms.memory.*` settings; they have been renamed to the `server.*` namespace. Update the dev Neo4j Dockerfile's NEO4J_ env vars to the new names. `dbms.security.procedures.unrestricted` is intentionally left untouched (the security namespace was not renamed). Verified locally: `docker build` + run, container starts cleanly with zero deprecation warnings in the startup log. Fixes LDFLK#398
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Neo4j dev Docker image configuration to use the newer Neo4j 5.x server.* setting names via environment variables.
Changes:
- Replace deprecated
dbms.memory.*env vars withserver.memory.*equivalents - Replace
dbms.directories.*env vars withserver.directories.*equivalents
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several Neo4j environment variables in the Dockerfile from the 'dbms' namespace to the 'server' namespace to align with Neo4j 5 configuration standards. A review comment suggests also updating the 'NEO4J_dbms_security_procedures_unrestricted' variable to the 'server' namespace for consistency and to avoid potential deprecation warnings.
Address PR review feedback: NEO4J_dbms_security_procedures_unrestricted was renamed to NEO4J_server_security_procedures_unrestricted in Neo4j 5. Aligns development Dockerfile with the choreo Dockerfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Neo4j 5.x emits 7 deprecation warnings on every startup of the dev Neo4j container because
deployment/development/docker/neo4j/Dockerfilestill passes the legacyNEO4J_dbms_*environment variables. This PR renames them to the newserver.*namespace, matching the convention already used indeployment/choreo/development/docker/neo4j/Dockerfile.Changes
NEO4J_dbms_memory_pagecache_size→NEO4J_server_memory_pagecache_sizeNEO4J_dbms_memory_heap_initial__size→NEO4J_server_memory_heap_initial__sizeNEO4J_dbms_memory_heap_max__size→NEO4J_server_memory_heap_max__sizeNEO4J_dbms_directories_data→NEO4J_server_directories_dataNEO4J_dbms_directories_logs→NEO4J_server_directories_logsNEO4J_dbms_directories_import→NEO4J_server_directories_importNEO4J_dbms_directories_plugins→NEO4J_server_directories_pluginsNEO4J_dbms_security_procedures_unrestrictedis intentionally left as-is — thedbms.security.*namespace was not renamed in Neo4j 5, and the original issue's log did not flag it.Fixes #398
Prepared with AI assistance (Claude Code); reviewed by me before pushing.