Add Arena::map - #9
Open
Ratysz wants to merge 1 commit into
Open
Conversation
Owner
|
We talked about this with @sdleffler on Discord a little bit. I think this functionality is useful, but I'd like to explore the option of being able to collect from an iterator of |
Author
|
Sounds fine by me; in fact, I would prefer that as well, as it's strictly more versatile. Don't hesitate to close this whenever, should you settle on that approach. |
Owner
|
Hi, I wanted to post an updated comment on this. Years later, I still think we should not have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analogous to
Iterator::map(), array::map(), etc...My usecase is pretty much typestate pattern; I want to shed parts of stored items that aren't useful anymore, but I also want existing indices to remain valid.
Alternative approach is to allow constructing
Arena<T>from iterator of(Index, T). This could also help with implementing serialization further down the line.