fix: regression impacting Nano S applications installation when commit command was missed#172
Merged
Conversation
…t command was missed
iartemov-ledger
requested review from
a team,
apaillier-ledger and
yogh333
and removed request for
a team
apaillier-ledger
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ledgerblue 0.1.57added a newcompute_app_hash()call between loading the code and the final commit step. That function packs the API level as an unsigned byte (struct.pack(">B", api_level)). Nano S has no API level, so it passes -1 → struct.pack(">B", -1) raises (must be 0–255). The crash aborts .apdu generation after the load/CRC lines but before the commit line (e00000000109) → the app never finalizes → "does not install."(Newer devices pass a real api level ≥ 0, so they're unaffected.)