Skip to content

migrate to ruff#668

Open
mbrousset-ledger wants to merge 3 commits into
masterfrom
mbr/ruff
Open

migrate to ruff#668
mbrousset-ledger wants to merge 3 commits into
masterfrom
mbr/ruff

Conversation

@mbrousset-ledger

Copy link
Copy Markdown
Contributor
  • migrate to ruff
  • fix ruff linting defects
  • format with ruff
  • add .git-blame-ignore-revs

@ledger-wiz-cspm-secret-detection

ledger-wiz-cspm-secret-detection Bot commented Jul 2, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 1 Critical 3 Medium 2 Low
Software Management Finding Software Management Findings -
Total 1 Critical 3 Medium 2 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Comment thread speculos/mcu/button_tcp.py Fixed
Comment thread speculos/mcu/finger_tcp.py Fixed
Comment thread speculos/mcu/rle_custom.py Outdated
Comment thread speculos/mcu/nbgl.py Outdated
Comment thread speculos/mcu/button_tcp.py Dismissed
Comment thread speculos/mcu/finger_tcp.py Dismissed
@cedelavergne-ledger
cedelavergne-ledger force-pushed the mbr/ruff branch 2 times, most recently from 87d00c3 to 95d7d4b Compare July 10, 2026 15:31
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.83007% with 509 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.78%. Comparing base (93df48d) to head (b5e1119).

Files with missing lines Patch % Lines
speculos/main.py 0.00% 149 Missing ⚠️
speculos/mcu/bagl.py 0.00% 90 Missing ⚠️
speculos/mcu/seproxyhal.py 29.31% 41 Missing ⚠️
speculos/mcu/screen_text.py 0.00% 33 Missing ⚠️
speculos/mcu/rle_custom.py 20.58% 27 Missing ⚠️
speculos/mcu/vnc.py 0.00% 26 Missing ⚠️
speculos/mcu/screen.py 0.00% 25 Missing ⚠️
speculos/mcu/transport/usb.py 17.24% 24 Missing ⚠️
speculos/mcu/nbgl.py 9.52% 19 Missing ⚠️
speculos/mcu/apdu.py 0.00% 11 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
- Coverage   41.86%   41.78%   -0.08%     
==========================================
  Files         141      141              
  Lines       15688    15699      +11     
  Branches     1430     1430              
==========================================
- Hits         6567     6560       -7     
- Misses       8645     8663      +18     
  Partials      476      476              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants