Repository navigation
fix(gui): Claude theme bleed-through on mobile home - #26
Merged
daum110715 merged 12 commits intoJul 16, 2026
Merged
Conversation
Owner
🔍 Code Review — Request ChangesSummaryClaims to fix Claude theme bleed-through on mobile home, but is a massive PR (58 files, +3616/-1566 lines) with a fundamental problem. Critical Issues1. Claude theme does not exist in the codebase
2. Massive PR scope mismatch
3. Init order change is backwards for the stated problem
Warning Issues4. Recommendation: Request changes — define Claude theme in registry first, split PR into smaller pieces, use CSS custom properties instead of hardcoded
|
Collaborator
Author
Addressed review feedbackCritical
i18n
Ready for re-review on the theme registration fix. |
Collaborator
Author
Status
No further code changes planned on this PR unless requested. |
…shells Extract shared caption/close controls and wrap shells with ErrorBoundary. Refactor PCWindow/SCPWindow and related modals to use the shared chrome.
Add App Manager (PC/Mobile), app catalog, stronger windowManager/taskbar behavior, and desktop/home integration for multi-window workflows.
…history Avoid dropping in-flight messages when switching rooms; keep optimistic entries visible in chat history.
Delete dead use*Refactored composables that are no longer imported.
…tcut only Restore modern filesystem (rename/remove/storage backend) that was clobbered by an old cherry-pick, and only add the appmanager.desktop default shortcut. Also restore settings windows without custom-accent personalization deps.
Avoid hauling large local rewrites of PCChatWindow/PCFeedbackWindow. Pass windowInstance into PCWindow so multi-window chrome works.
daum110715
force-pushed
the
pr/claude-theme-fix
branch
from
July 16, 2026 03:45
824ddd2 to
02556e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Claude theme styling on mobile home screen app icons/labels so light theme styles do not bleed into Claude.
Depends on
Changes