Add TODOs for fixing NodeJS pipe 3 & 4 support - #1
Conversation
Added TODO comments and commented-out code to: - `src/shared/inc/lxinitshared.h`: Suggest increasing `LX_INIT_STD_FD_COUNT` and `LX_INIT_UTILITY_VM_CREATE_PROCESS_SOCKET_COUNT`. - `src/linux/init/init.cpp`: Show how to create, dup2, and relay extra pipes in `InitCreateProcessUtilityVm`. - `src/windows/common/interop.cpp`: Note where to handle extra unmarshaled handles. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Investigated the codebase to identify why Node.js pipes 3 & 4 were not working. Added TODO comments and commented-out code examples to the relevant files (
src/shared/inc/lxinitshared.h,src/linux/init/init.cpp,src/windows/common/interop.cpp) to guide the manual implementation of support for these extra pipes. The changes include instructions on creating pipes, duplicating file descriptors, and updating the relay loop to handle the additional communication channels.PR created automatically by Jules for task 10330263379353002424 started by @Lightning00Blade