Browser integration added (HTML5 Canvas)#4
Open
dilucide wants to merge 16 commits into
Open
Conversation
dilucide
commented
Jan 24, 2016
dilucide
commented
- Browser integration works
- Animation working
- Single frame working
- Browser testfile provided
- Gulpfile updated
…data.js to start lines with beginPath in order to ensure proper clearing of the canvas. Added Test-HTML. TODO: Update gulpfile
Owner
|
Hey, two things:
|
…o stop animation. May consider a more elegant way.
…ex2.html using the updated pivi version. Animation is now started with startAnimation(data) and stopped by calling stopAnimation().
…mation: when doing so, on the first call, the animation would not start, but merely be stopped. this was due to failing to add the data parameter for the delayed startAnimation after stopping the previous one, resulting in initialize exiting prematurely due to the undefined data variable at data.split(...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.