Skip to content

Fixup: Twelve days of AoC#1

Merged
Lollyde merged 3 commits into
Lollyde:mainfrom
xsebek:twelve-days-of-aoc
Dec 7, 2025
Merged

Fixup: Twelve days of AoC#1
Lollyde merged 3 commits into
Lollyde:mainfrom
xsebek:twelve-days-of-aoc

Conversation

@xsebek

@xsebek xsebek commented Dec 7, 2025

Copy link
Copy Markdown
  • Use simple string literal, const &str is hard 😞
  • Fixup error message and comments
  • Fixup month number 12

@xsebek

xsebek commented Dec 7, 2025

Copy link
Copy Markdown
Author

Hi @Lollyde! I saw your PR fspoettel#82 and wanted to use it in my repo this year.

I noticed you replaced the 12 month of December by days!() macro, so I fixed that. I also wanted to improve the error messages, but as you said, constant strings are hard in Rust. 😩

Good luck getting your changes merged upstream! 👍

@Lollyde

Lollyde commented Dec 7, 2025

Copy link
Copy Markdown
Owner

...hhuh, youre right, i did mess up the today command! turns out it just happens to work for any configurations past 2024. note to self, do not write code and open a pr in a hurry like this

@Lollyde
Lollyde merged commit c2bb044 into Lollyde:main Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants