Skip to content

モブプロプロジェクトが開始したため、プロジェクト紹介ページにカードを追加 - #293

Open
tomoyahiroe wants to merge 6 commits into
mainfrom
daichi/add-mobproject
Open

モブプロプロジェクトが開始したため、プロジェクト紹介ページにカードを追加#293
tomoyahiroe wants to merge 6 commits into
mainfrom
daichi/add-mobproject

Conversation

@tomoyahiroe

@tomoyahiroe tomoyahiroe commented Sep 9, 2026

Copy link
Copy Markdown
Member
  • app/projects/page.tsx にモブプロプロジェクトの情報をJSON形式で追加

close #282

close #285

@tomoyahiroe
tomoyahiroe requested review from a team and KinuShunGH September 9, 2026 13:53

@Shion1305 Shion1305 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変更がありません

@Shion1305
Shion1305 requested a review from a team September 9, 2026 13:55
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Deployed on https://dev-pr-293-birbz3fm6q-an.a.run.app

@KinuShunGH KinuShunGH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変更が一つもありません

@github-actions

Copy link
Copy Markdown

Deployed on https://dev-pr-293-birbz3fm6q-an.a.run.app

Comment thread app/projects/page.tsx Outdated
id: 4,
title: "モブプロ",
description:
"Lumosのメンバー全員で、lumos-web の開発に取り組むモブプログラミングを9月に開催します。実際にコードを書きながら、開発の進め方やコードレビューの方法を学び、メンバー全員が開発とレビューに参加できる状態を目指します。",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lumos Webが正式表記かなみたいなことは考えてたけどどうしよう? 特に厳格には決まってない

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中の人しか lumos-web は伝わらない可能性

Comment thread app/projects/page.tsx Outdated
"Lumosのメンバー全員で、lumos-web の開発に取り組むモブプログラミングを9月に開催します。実際にコードを書きながら、開発の進め方やコードレビューの方法を学び、メンバー全員が開発とレビューに参加できる状態を目指します。",
image: "/assets/Lumoslogo.png",
status: "進行中",
technologies: ["next.js", "typescript", "css", "firebase", "react"],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technologiesは大文字小文字しっかりしたい 👀

Comment thread app/projects/page.tsx
image: "/assets/Lumoslogo.png",
status: "進行中",
technologies: ["next.js", "typescript", "css", "firebase", "react"],
leaderId: 967802261201887242,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: leaderId の実装デタラメな値になってるので、実装を修正する必要はある (別PRでなおそう)

@tomoyahiroe

Copy link
Copy Markdown
Member Author
  • リーダーのリンクが機能しない
  • 言語・フレームワークの大文字、小文字を公式に合わせたい
  • lumos-webを サークルサイトという単語に統一

@github-actions

Copy link
Copy Markdown

Deployed on https://dev-pr-293-birbz3fm6q-an.a.run.app

2 similar comments
@github-actions

Copy link
Copy Markdown

Deployed on https://dev-pr-293-birbz3fm6q-an.a.run.app

@github-actions

Copy link
Copy Markdown

Deployed on https://dev-pr-293-birbz3fm6q-an.a.run.app

@futuu-human futuu-human left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Shumi1225 Shumi1225 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

Copy link
Copy Markdown

Deployed on https://dev-pr-293-birbz3fm6q-an.a.run.app

@Shumi1225
Shumi1225 enabled auto-merge (squash) September 10, 2026 13:42
@Shumi1225
Shumi1225 disabled auto-merge September 10, 2026 13:42

@atchonburike atchonburike left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

9 participants