feat: allow sensors' GUI preview subwindow to start minimized#107
Merged
Conversation
Add a new common sensor XML tag <preview_win_visible> (default true) so that camera/RGBD camera preview subwindows can start minimized instead of opened, without affecting the simulated sensor data. Default preserves prior behavior for existing world.xml files.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughCamera and RGBD camera sensors now accept ChangesSensor Preview Visibility
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SensorXML
participant SensorBase
participant WorldGUI
SensorXML->>SensorBase: Parse preview_win_visible
WorldGUI->>SensorBase: Query previewWinVisible()
WorldGUI->>WorldGUI: Create preview subwindow
WorldGUI->>WorldGUI: Minimize when visibility is false
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<preview_win_visible>(defaulttrue) controlling whether a camera/RGBD-camera GUI preview subwindow starts opened or minimized, without affecting the simulated sensor data itself.true, so existingworld.xmlfiles without the tag behave exactly as before.definitions/camera.sensor.xmlanddefinitions/rgbd_camera.sensor.xmlto expose${preview_win_visible|true}.mvsim_tutorial/demo_camera.world.xmlas a usage example (left explicitlytrue/visible).agents.md.Test plan
make -j$(nproc) mvsim-simulatorbuilds cleanlymvsim launch mvsim_tutorial/demo_camera.world.xml --headless) withpreview_win_visible="true"and"false"both parse and run without exceptionsfalse(not verifiable in this headless dev environment)Summary by CodeRabbit
New Features
preview_win_visiblesetting, which defaults to opened (true).Documentation