Collection page finalization#2144
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ffont
reviewed
Jun 12, 2026
ffont
left a comment
Member
There was a problem hiding this comment.
Thanks a lot, merging this right now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
num_soundsThe old increment/decrement signals were replaced with a single recount (Collection.update_num_sounds()) fired only atpost_saveandpost_delete{% if paginator.count %}replaced with{% if collection.num_sounds > 0 %}which stays consistent across search queries -> fixes search stacking and empty collections.Added
Packs, added:LicenseSummaryMixinshared withPackget_collection_tags_bw)indicator on collection cards shown to owners/maintainers
$orangecolor variable)SoundManager.sounds_for_collection(): lightweight accepted-sounds queryset, reused bybulk_sounds_for_collectionCollection.user_is_owner_or_maintainer()centralizing the permission check used by views,forms and templatetags
Performance fixes
Licenseobject once and caches it (benefits packs too)display_collectiontemplatetag accepts aCollectioninstance, avoiding a re-fetch per cardScreenshots about the visual changes: