Skip to content

Collection page finalization#2144

Merged
ffont merged 6 commits into
MTG:masterfrom
5aola:collection-page-finalize
Jun 12, 2026
Merged

Collection page finalization#2144
ffont merged 6 commits into
MTG:masterfrom
5aola:collection-page-finalize

Conversation

@5aola

@5aola 5aola commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Fixed

  • num_sounds The old increment/decrement signals were replaced with a single recount (Collection.update_num_sounds()) fired only at post_save and post_delete
  • At collection page {% if paginator.count %} replaced with {% if collection.num_sounds > 0 %} which stays consistent across search queries -> fixes search stacking and empty collections.

Added

  • Redesigned collection page on the standard two-column layout to match Packs, added:
    • Overall rating stars,
    • Owner info and follow/unfollow button,
    • License summary on the collection page via a new LicenseSummaryMixin shared with Pack
    • Tag cloud built from the collection's sounds (get_collection_tags_bw)
  • Visibility setting (Public/Private radio) in the create-collection modal, and a visibility
    indicator on collection cards shown to owners/maintainers
  • "Featured" badge and card styling for featured sounds (new $orange color variable)
  • Maintainers can now edit featured sounds
  • SoundManager.sounds_for_collection(): lightweight accepted-sounds queryset, reused by
    bulk_sounds_for_collection
  • Collection.user_is_owner_or_maintainer() centralizing the permission check used by views,
    forms and templatetags

Performance fixes

  • License summary resolves the License object once and caches it (benefits packs too)
  • display_collection templatetag accepts a Collection instance, avoiding a re-fetch per card

Screenshots about the visual changes:

Screenshot 2026-06-12 at 12 34 38

@5aola 5aola changed the title Collection page finalisation Collection page finalization Jun 12, 2026
5aola and others added 2 commits June 12, 2026 12:41
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@5aola 5aola marked this pull request as ready for review June 12, 2026 10:55

@ffont ffont left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, merging this right now!

@ffont ffont merged commit c2faa77 into MTG:master Jun 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants