fix card multiverseid type so to work with the actual type from api - #11
Open
Ion-manden wants to merge 1 commit into
Open
fix card multiverseid type so to work with the actual type from api#11Ion-manden wants to merge 1 commit into
Ion-manden wants to merge 1 commit into
Conversation
|
Contacting someone to see if I can get this PR approve/pushed through. |
walanpat
approved these changes
Jun 13, 2022
|
Is there an update on this PR? Or does anyone know if there's someone who can land this change? |
|
BUMP |
Author
|
Sadly looks like all the repoes here are unmaintained now. You should be able to just use my version by importing from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, the current type for card.MultiverseId is not correct, go sdk expect
uint32but the api response with astring.