feat: Add in-app filesystem folder picker dialog with SAF fallback - #23
Merged
Conversation
Owner
|
Nice work, the SAF fallback and the suspend-lambda design are exactly right. A few things before merge:
|
Contributor
Author
|
Thanks for the detailed review! I've addressed all 5 points in a single updated commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a built-in, theme-consistent in-app folder chooser dialog (FileSystemFolderPickerDialog) for selecting backup and download directories on Android, as an enhancement to the system Storage Access Framework (SAF) picker.
What's Changed
Why
On certain Android versions and custom ROMs, the default SAF (OpenDocumentTree) can be unintuitive or restricted. Providing a direct in-app folder browser that matches TeleDrive's UI theme gives users a smoother, more responsive experience while preserving standard SAF compatibility.
Testing