You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm assuming it was intentional, but it looks like where EntityLib on the PvPHub Maven... changed? I updated it within the last commit there due to that.
That latest commit patches an issue with NameTags staying in place when a user vanishes/unvanished or a vanish plugin features a "vanish level" system.
Repro steps:
Person A = lower vanish, no vanish players Person B = Higher vanish players
When Person B logs out while flying mid-air, and logs back in, the name tag is visible to Person A.
-> While still being vanished, the nametag won’t follow along with Person A, it will remain where they spawned.
-> We can see Person B sneak due to the nametag that becomes slightly transparent.
When Player B does decide to do /vanish, the nametag will connect back to its respective player, thus moving from where they first spawned.
-> The nametag will remain where they first spawned, even if they tpa to somewhere else, example to spawn.
-> It will still remain where it spawned even if the player does unvanish to that location.
We believe that the problem starts when Person B logs into the spawn the first time. Afterwards the nametag problem disappears once they vanish and unvanish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
folia support!
running on prod on
play.forgottensmp.netcredit to @MidnightTale for the original fork. It was a few months old - I bumped up to upstream and ran prod testing.