Fix #91 - #95
Closed
andreleblanc11 wants to merge 1 commit into
Closed
Conversation
Member
|
This is interesting, but the watch config has |
Contributor
|
This is a weird fix. the whole point of the restart_server test is to confirm that it doesn't lose any posts across restarts. If you have to touch files after each start... well that means it isn't working and should not pass, no? |
Member
Author
|
You are right. I didn't look long enough into the problem and forgot about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #91 (comment) on the most recent analysis done regarding this issue.
Sometimes in the restart_server flow test the watch will miss posting 1 or more files due to the timing of the sr3 restart being done.
If we touch all the files after the last restart, this should assure all files get posted downstream due to the watchdog noticing them if ever any are missed.
I also don't think this is a problem in the watch code due to the nature of how the watchdog works.
I ran the restart_server flow test without the patch 3 times and it only passed 1/3 times.
I ran the restart_server flow test WITH the patch 5 times and it passed 5/5 times.
All of these runs were on a RHEL8 machine as it seemed to be the environment to trigger the problem the most often. This problem also occurs on the GitHub action runs.