Wire series language into MetronInfo.xml output - #268
Merged
Conversation
Map the series language from the Metron API response onto Metadata.series.language so it's written as the `lang` attribute on the Series element in MetronInfo.xml. Adds unit and end-to-end tests covering the mapping and the resulting XML output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Metadata.series.languageso it's written as thelangattribute on theSerieselement when writing MetronInfo.xml.MetadataMapper._set_series_infomapping the language field.Metadataobject through darkseid'sMetronInfowriter and assert thelangattribute is present (or omitted when no language is set).