Speed up test suite and remove unused backfill command - #609
Merged
Conversation
Tests were paying full PBKDF2 cost (~0.5s/hash) on every user creation, and fixture chains often create several users per test, making this the dominant cost by far. Switch to MD5PasswordHasher under pytest, and add --reuse-db to skip rebuilding the test database from migrations on every invocation. Together these cut the full suite from ~13m40s to ~51s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
created_by/edited_byuser), making this the dominant cost by far. Switch toMD5PasswordHasherunder pytest only — verified the override is inert outside pytest and thatpytestisn't installed in a production (--no-dev) sync, so production hashing is unaffected.--reuse-dbto skip rebuilding the test database from ~103 migrations on every invocation; safe in CI since each job starts from a fresh Postgres container. Documented the--create-dbescape hatch for local migration changes.issue_ratings.backfill_issue_ratings, a one-time management command that already did its job, along with its tests and an unusedother_rating_usertest fixture.Together the two speed changes cut the full suite from ~13m40s to ~51s locally (same 1780 passed / 2 skipped).
Test plan
PASSWORD_HASHERSis only set when"pytest" in sys.modules, and confirmedpytestis excluded from auv sync --no-devinstall