Track Metron's X-Cache header via Session.last_cache_status - #158
Merged
Conversation
Metron now reports whether cached endpoints served a response from cache ("HIT") or generated it fresh ("MISS") via the X-Cache header. Since the header is per-endpoint (only cached views send it), a missing header resets the status to None rather than keeping a stale value from an earlier, cached endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HIT) or generated it fresh (MISS) via a newX-Cacheresponse header (Metron-Project/metron#604).Session.last_cache_status, which mirrors the existingrate_limit_statuspattern: updated from response headers after every request, thread-safe via its own lock.X-Cacheis per-endpoint (only Metron's cached views send it — user-scoped viewsets like pull list/collection/wish list never do), a response missing the header resets the status toNoneinstead of preserving a staleHIT/MISSfrom an earlier, cached endpoint.