Repository navigation
Add Arabic locale (#11) - #14
Merged
Merged
Conversation
Aaqibhafeezkhan
commented
Oct 22, 2026
Contributor
Author
There was a problem hiding this comment.
The changes outside ar.json address the same CI failure encountered while validating the Arabic locale addition. The installer generator's locale-ID mapping did not satisfy the existing test for Japanese (ja) and Brazilian Portuguese (pt-br) under Python 3.13. I added explicit LCID mappings in build_installer.py to make the installer generation deterministic and compatible with the test expectations. Although unrelated to Arabic translation content itself, this shared fix was needed for the PR's CI validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ar) locale as a standalone JSON file.