Skip to content

Ensure multiple suppressions work as expected #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattmook wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure multiple suppressions work as expected #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mobsfscan/mobsfscan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def post_ignore_files(self):
# any matches in the file for the rule
if self.suppress_pm_comments(file, rule_id):
# remove all matches of the file for the rule
tmp_files = self.remove_matches(file, files)
tmp_files = self.remove_matches(file, tmp_files)
if len(tmp_files) == 0:
del_keys.add(rule_id)
details['files'] = tmp_files
Expand Down
12 changes: 12 additions & 0 deletions tests/assets/src/dot_mobsf/scan_but_ignore2.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
private fun showN(show: Boolean) {

xyz.visibility = if (show) View.GONE else View.VISIBLE
xyz.animate()

}

Log.e("foo", foo.toString())



android.secret_key="supersecret key" // mobsf-ignore: android_kotlin_hardcoded