fix(agent-core): session approval for Write/Edit at tool scope#901
fix(agent-core): session approval for Write/Edit at tool scope#901Cyning12 wants to merge 2 commits into
Conversation
…hotAI#437) Approve-for-session on Write/Edit caches tool-name rules so subsequent writes in the same session do not re-prompt. Fixes MoonshotAI#437. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 72b15b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72b15b8c77
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (parsed.argPattern !== undefined && (toolName === 'Write' || toolName === 'Edit')) { | ||
| return parsed.toolName; |
There was a problem hiding this comment.
When a user approves any Write/Edit for the session, this stores the bare tool name (for example Write). I checked createPermissionDecisionPolicies: SessionApprovalHistoryPermissionPolicy runs before SensitiveFileAccessAskPermissionPolicy and GitControlPathAccessAskPermissionPolicy, so a later write to .env, SSH keys, or .git/config is approved by the session cache instead of showing the protected-path prompt that would otherwise fire. Keep the cached rule scoped enough, or ensure protected-path asks still run before the session grant is applied.
Useful? React with 👍 / 👎.
2 participants
Related Issue
Fixes #437
Problem
In the TUI, choosing "Approve for this session" on Write or Edit did not behave differently from "Approve once": subsequent writes in the same session still showed approval prompts. Issue comment reproduces this when writing multiple files under the same directory after selecting session approval.
What changed
PermissionManagernow stores a tool-name session rule (for exampleWrite) instead of a path-specific rule (for exampleWrite(/path/a.ts)).session-approval-historycan then match later Write/Edit calls to different paths in the same session without re-prompting.Implementation is limited to
packages/agent-core(resolveSessionApprovalRule+ tests). TUI adapter already mapsapproved_for_sessiontoscope: 'session'; no TUI code changes in this PR.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Made with Cursor