Skip to content

Replace LD19 with Hesai JT16 ROS 2 driver - #44

Merged
MrBearing merged 4 commits into
jazzyfrom
feature/issue-30-jt16-driver
Aug 21, 2026
Merged

MrBearing merged 4 commits into
jazzyfrom
feature/issue-30-jt16-driver

Conversation

@MrBearing

Copy link
Copy Markdown
Owner

Summary

  • remove LD19 repositories, launch integration, and udev rule
  • add a SANEHAL JT16 launch using hesai_ros_driver v2.0.12 and the serial configuration
  • integrate JT16 into the Raspberry Pi bringup and document PointCloud2, TF, QoS, timestamp, and device permissions
  • install undeclared Hesai system dependencies in Jazzy CI

Validation

  • colcon build --packages-up-to sanehal_bringup
  • colcon test --packages-select hesai_ros_driver sanehal sanehal_bringup sanehal_vehicle_description
  • colcon test-result --verbose: 17 tests, 0 errors, 0 failures
  • launch argument expansion for jt16.launch.py and sanehal.launch.py
  • vcs, YAML, XML, Python AST, and udev rule validation
  • confirmed Hesai v2.0.12 and SDK submodule revision in the workspace

Hardware status

  • the driver opens /dev/jt16_rs485 and /dev/jt16_rs232 and advertises /lidar_points with Reliable/Volatile QoS
  • the connected RS485 port produced no bytes during the test, so PointCloud2 rate, fields, timestamps, packet-loss values, and alignment remain blocked on JT16 power/wiring/serial-output diagnosis
  • /lidar_imu remains disabled until the hardware output is validated
  • upstream v2.0.12 required SIGKILL after it did not exit on SIGINT/SIGTERM

Closes #30

@MrBearing

Copy link
Copy Markdown
Owner Author

@codex review

@MrBearing MrBearing self-assigned this Aug 21, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4127572f59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci_jazzy.yaml
Comment thread README.md Outdated
@MrBearing

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63763888ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sanehal_bringup/launch/sanehal_rviz.launch.py
Comment thread sanehal_bringup/launch/sanehal_rviz.launch.py
@MrBearing

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 94c7ee34cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sanehal_bringup/launch/sanehal_rviz.launch.py
@MrBearing

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 2ed1eb4277

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@MrBearing
MrBearing merged commit e216047 into jazzy Aug 21, 2026
1 check passed
@MrBearing
MrBearing deleted the feature/issue-30-jt16-driver branch August 21, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LD19依存を削除してHesai JT16 ROS 2 driverを導入する

1 participant